Updated cgi.js with try\catch to stop crash on invalid headers #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeJS 5.10.1. Headers from buffer stream not being parsed correctly causing a crash when trying to set them for the response object. Try\Catch added to prevent this. The problem comes from header-stack, working on a pull request for that to parse the headers correctly. This error may be unique to my cgi however this fix should not break any other implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeJS 5.10.1. Headers from buffer stream not being parsed correctly causing a crash when trying to set them for the response object.
Try\Catch added to prevent this.
The problem comes from header-stack, working on a pull request for that to parse the headers correctly.
This error may be unique to my cgi however this fix should not break any other implementations.